Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image not positioning correctly after rotate #396

Open
stdCh opened this issue Oct 10, 2017 · 8 comments
Open

Image not positioning correctly after rotate #396

stdCh opened this issue Oct 10, 2017 · 8 comments
Labels

Comments

@stdCh
Copy link

stdCh commented Oct 10, 2017

Steps:

  1. Upload photo
  2. Zoom
  3. Positioned image to crop
  4. Rotate

Image is not positioned to previous viewport area.

@im-pro-at
Copy link
Contributor

It also gets wrongly crop sometimes
I think it have something to do with enforceBoundary: false
For a quick fix I rotate the image externally and then reload it!

@im-pro-at
Copy link
Contributor

after more investigation it has something to do with the zoom at maximum ...

@danazkari
Copy link

My steps are a bit different but the outcome is the same, a wrongly cropped image

http://jsbin.com/lakicab/edit?html,js,output

Load the URL, zoom-out, then hit the 'Rotate' button.

image

I think I could fix that issue artificially on my end, adjusting the zoom value so that no whitespace is shown, but that's a lot of unnecessary work if this issue gets solved 😄

@thedustinsmith
Copy link
Contributor

Thanks for the jsbin, it makes these things so much easier. I'll try to get this fixed in 2.5.2

@danazkari
Copy link

@thedustinsmith glad it helped! If you need anything else from me, please let me know!

@thedustinsmith
Copy link
Contributor

Since you offered 😏 ....

If you could pull this branch: https://github.com/Foliotek/Croppie/tree/pre-2.5.2

I've got a potential fix for the issue in there. Would you mind being my second pair of eyes and see if it fixes your issue or breaks any of your functionality?

@danazkari
Copy link

For sure mate! Consider it done!

I gotta finish some stuff first on my project, but I'll take a look at it in the afternoon if you don't mind.

@Hesesses
Copy link

any estimates when 2.5.2 will be released? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants