Fix enforce boundary #484
Merged
Fix enforce boundary #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 21, 2018 17:07
Whenvever enforceBoundary is set to false, the image cannot get smaller the original image size. Adding conditional that will skip this check if enforceBoundary = false
|
Awesome - thanks for the PR. I don't have any time this week, but I'll look at this first thing on Monday. |
|
Thanks @thedustinsmith 👍 |
|
Thanks @BVazquezAlvarez for finding the related issues, @thedustinsmith have you had a chance to review the PR? |
|
Thanks @jlane9 ! This fixed the issues I was having with enforceBoundary. |
|
It solves the problem for me also! Great job! |
|
@thedustinsmith Please, review this if you have time enough. It's a very important fix for enforce boundary. |
|
Haven't forgotten about this one. I've got time blocked off tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were attempting to use the enforceBoundary toggle (knowing full well it was still experimental), but kept running into the issue where if the image was scaled out it would cause the image to be cropped and positioned all haphazardly. We think we've figured out the issue was due to minimum sizes were being set ex.
width = Math.min(width, self._originalImageWidth);because the images themselves would not get any smaller only the position would change.