Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix center image #666

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Fix center image #666

wants to merge 11 commits into from

Conversation

mokraemer
Copy link

if the resulting canvas element is not of the same size as the picture, the picture was not centered in the canvas element

@mandaputtra
Copy link

do this fix #419 ?

@mokraemer
Copy link
Author

I would say "yes". If I use our patched version (https://static.qmsystems.de/js/lib/croppie.js), I can't reproduce the issues I see with the original lib.
Since this is the first time I use git, not all patches from obove apply to this FR/bug.

@vandensudarsono
Copy link

it seem your changes is not included in v.2.6.4 version.

@mokraemer
Copy link
Author

yes, no one wants to merge...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants