Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add polymorphic associations support #640

Merged
merged 17 commits into from
Jan 18, 2024

Conversation

nicolasalexandre9
Copy link
Member

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

matthv
matthv previously approved these changes Dec 18, 2023
spec/lib/forest_liana/schema_file_updater_spec.rb Outdated Show resolved Hide resolved
@matthv
Copy link
Member

matthv commented Dec 21, 2023

Copy link

codeclimate bot commented Jan 16, 2024

Code Climate has analyzed commit b941d2d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 76.8% (55% is the threshold).

This pull request will bring the total coverage in the repository to 50.1%.

View more on Code Climate.

@nicolasalexandre9 nicolasalexandre9 merged commit 2d43bc3 into main Jan 18, 2024
6 checks passed
@nicolasalexandre9 nicolasalexandre9 deleted the feat/add-polymorphic-support branch January 18, 2024 15:13
forest-bot added a commit that referenced this pull request Jan 18, 2024
# [8.1.0](v8.0.17...v8.1.0) (2024-01-18)

### Features

* add polymorphic associations support ([#640](#640)) ([2d43bc3](2d43bc3))
@forest-bot
Copy link
Member

🎉 This PR is included in version 8.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 8.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Watanabe1011 added a commit to Watanabe1011/Forest-Rails that referenced this pull request Jun 3, 2024
# [8.1.0](ForestAdmin/forest-rails@v8.0.17...v8.1.0) (2024-01-18)

### Features

* add polymorphic associations support ([#640](ForestAdmin/forest-rails#640)) ([2d43bc3](ForestAdmin/forest-rails@2d43bc3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants