Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for workspace context in charts #649

Merged
merged 18 commits into from
Feb 29, 2024
Merged

Conversation

matthv
Copy link
Member

@matthv matthv commented Feb 14, 2024

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

end
end

def self.inject_context_in_value_custom(value)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method inject_context_in_value_custom has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Copy link

codeclimate bot commented Feb 29, 2024

Code Climate has analyzed commit fa87532 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 98.7% (55% is the threshold).

This pull request will bring the total coverage in the repository to 50.4%.

View more on Code Climate.

Copy link
Member

@nicolasalexandre9 nicolasalexandre9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@matthv matthv merged commit 3e98864 into main Feb 29, 2024
6 checks passed
@matthv matthv deleted the feat/context-injector branch February 29, 2024 09:32
@forest-bot
Copy link
Member

🎉 This PR is included in version 9.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Feb 29, 2024
# [9.2.0](v9.1.10...v9.2.0) (2024-02-29)

### Features

* add support for workspace context in charts ([#649](#649)) ([3e98864](3e98864))
Watanabe1011 added a commit to Watanabe1011/Forest-Rails that referenced this pull request Jun 3, 2024
# [9.2.0](ForestAdmin/forest-rails@v9.1.10...v9.2.0) (2024-02-29)

### Features

* add support for workspace context in charts ([#649](ForestAdmin/forest-rails#649)) ([3e98864](ForestAdmin/forest-rails@3e98864))
montedev0516 added a commit to montedev0516/Artizyou-Platform that referenced this pull request Nov 7, 2024
# [9.2.0](ForestAdmin/forest-rails@v9.1.10...v9.2.0) (2024-02-29)

### Features

* add support for workspace context in charts ([#649](ForestAdmin/forest-rails#649)) ([3e98864](ForestAdmin/forest-rails@3e98864))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants