Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): allow user using context variables into query #679

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

matthv
Copy link
Member

@matthv matthv commented Jun 7, 2024

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

Copy link

codeclimate bot commented Jun 7, 2024

Code Climate has analyzed commit b13bad5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (55% is the threshold).

This pull request will bring the total coverage in the repository to 50.4%.

View more on Code Climate.

Copy link
Member

@nicolasalexandre9 nicolasalexandre9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@matthv matthv merged commit 3020a78 into main Jun 7, 2024
6 checks passed
@matthv matthv deleted the fix/workspace-livequery-contextvariable branch June 7, 2024 13:50
forest-bot added a commit that referenced this pull request Jun 7, 2024
## [9.3.7](v9.3.6...v9.3.7) (2024-06-07)

### Bug Fixes

* **query:** allow user using context variables into query ([#679](#679)) ([3020a78](3020a78))
@forest-bot
Copy link
Member

🎉 This PR is included in version 9.3.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants