Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve quey with duplicate alias #687

Merged
merged 10 commits into from
Sep 10, 2024
Merged

fix: improve quey with duplicate alias #687

merged 10 commits into from
Sep 10, 2024

Conversation

matthv
Copy link
Member

@matthv matthv commented Sep 3, 2024

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@codeclimate CodeClimate
Copy link

codeclimate bot commented Sep 6, 2024

Code Climate has analyzed commit 87ffd53 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 62.1% (55% is the threshold).

This pull request will bring the total coverage in the repository to 50.6%.

View more on Code Climate.

nicolasalexandre9
nicolasalexandre9 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@nicolasalexandre9 nicolasalexandre9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matthv matthv changed the title fix: resource getter query fix: improve quey with duplicate alias Sep 10, 2024
@matthv matthv merged commit a163407 into main Sep 10, 2024
6 checks passed
@matthv matthv deleted the fix/resource-getter-query branch September 10, 2024 07:55
forest-bot added a commit that referenced this pull request Sep 10, 2024
@forest-bot
chore(release): 9.3.15 [skip ci]
9ea0141 
## [9.3.15](v9.3.14...v9.3.15) (2024-09-10)

### Bug Fixes

* improve quey with duplicate alias ([#687](#687)) ([a163407](a163407)), closes [#512](#512)
@forest-bot
Copy link
Member

🎉 This PR is included in version 9.3.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasalexandre9 nicolasalexandre9 nicolasalexandre9 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthv @forest-bot @nicolasalexandre9