Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update regex validation #94

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update regex validation #94

wants to merge 1 commit into from

Conversation

ryansrofe
Copy link
Collaborator

This update includes additional valid characters

Fixes #93

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested locally within Figma.

Checklist: (Feel free to delete this section upon completion)

  • I have performed a self-review of my own code
  • I have run all builds, tests, and linting and all checks pass

@ryansrofe
update regex validation
9ca5cc1 
includes additional valid characters
@ryansrofe ryansrofe added the bug Something isn't working label Jun 14, 2024
@ryansrofe ryansrofe added this to the Version 4 milestone Jun 14, 2024
@ryansrofe ryansrofe requested a review from cpresler June 14, 2024 17:50
@ryansrofe ryansrofe self-assigned this Jun 14, 2024
@ryansrofe ryansrofe linked an issue Jun 14, 2024 that may be closed by this pull request
Bug with links when using some special characters that are actually valid to use #93
Open
cpresler
cpresler approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@cpresler cpresler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't pull this and test locally, but based on the code changed this should be fine. If you'd like me to pull and run some manual tests I'm happy to, I just don't want to hold this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpresler cpresler cpresler approved these changes

Assignees

@ryansrofe ryansrofe

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 4
Development

Successfully merging this pull request may close these issues.

Bug with links when using some special characters that are actually valid to use
2 participants
@ryansrofe @cpresler