This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Improve wording #15
Open
trusktr
wants to merge
2
commits into
FormidableLabs:master
Choose a base branch
from
trusktr:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve wording #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And, to prove how confused I was, I fix my wrong wording. 🤣 |
ryan-roemer
reviewed
Feb 12, 2018
* Replaces `package.json:dependencies` with | ||
`ARCHETYPE-dev/package.json:dependencies` | ||
* Replaces `package.json:dependencies` that were copied from root with | ||
`ARCHTYPE-dev/package.json:dependencies` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: s/ARCHTYPE/ARCHETYPE/
ryan-roemer
reviewed
Feb 12, 2018
for development tasks only. | ||
* `dev/package.json` | ||
* `../ARCHETYPE-dev/package.json` | ||
for development tasks only. One of the following should exist: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, One, and only one, of the following
?
ryan-roemer
suggested changes
Feb 12, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping clarify! Just have one typo + one possible additional tweak and then I'll merge...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was confusing.