Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pkce android #284

Merged
merged 5 commits into from
Mar 31, 2019
Merged

Use pkce android #284

merged 5 commits into from
Mar 31, 2019

Conversation

sebk
Copy link
Contributor

@sebk sebk commented Mar 29, 2019

  • Implements Disable PKCE on Android #279
  • Summary of the work: Moved the parameter usePKCE to the general config (for Android and iOS), to be able to disable PKCE also on Android.
  • include steps to verify
  • update tests (if applicable)
  • update readme (if applicable)
  • update typescript definitions (if applicable)

kadikraman
kadikraman suggested changes Mar 31, 2019
View reviewed changes
Copy link
Contributor

@kadikraman kadikraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'm happy to merge this, if you are ok to fix the breaking change 🙏

index.js Outdated Show resolved Hide resolved
@kadikraman kadikraman added this to the Next Minor Release 🎉 milestone Mar 31, 2019
@kadikraman kadikraman merged commit e7468f1 into FormidableLabs:master Mar 31, 2019
@kadikraman
Copy link
Contributor

Released in v4.3.0

@kpelelis kpelelis mentioned this pull request Apr 1, 2019
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadikraman kadikraman kadikraman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sebk @kadikraman