Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/androidx #328

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Feature/androidx #328

merged 1 commit into from
Jul 15, 2019

Conversation

kadikraman
Copy link
Contributor

Fixes #326

Description

Upgrade to use androidx instead of the old Android support libraries.

Steps to verify

Install react-native-app-auth from this PR, and add the following to the project's gradle.properties file:

android.useAndroidX=true
android.enableJetifier=true

The app should build.

@kadikraman kadikraman added this to the Next Major Release 🚀 milestone Jun 20, 2019
@kadikraman
Copy link
Contributor Author

This is a breaking change. React Native will be using AndroidX in their 0.60 release, at which point we will add AndroidX here as well.

In the meanwhile, for anyone wanting to use AndroidX on their project, you can install from branch

yarn add FormidableLabs/react-native-app-auth#feature/androidx

@wangsha
Copy link

wangsha commented Jul 3, 2019

+1

@kadikraman kadikraman merged commit cffea61 into master Jul 15, 2019
@kadikraman
Copy link
Contributor Author

This is included in the next release candidate - install with yarn add react-native-app-auth@next

@kadikraman
Copy link
Contributor Author

Released in v5.0.0 🎉

@jpdriver jpdriver deleted the feature/androidx branch July 12, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@Nullable
2 participants