Stop onActivityResult from proceeding when intent is null to prevent app from crashing #352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #130
Description
There are at least several cases where the app crashes in onActivityResult method when received data intent is null (more about this - #130). The cause of the crash is that AuthorizationResponse.fromIntent method (imported from net.openid.appauth) has a null checker method, which throws NullPointerException and the user is presented with a native crash info screen. I'm proposing to add a check for data intent being null, and terminate the authorization process if it is (reject the the promise with error message and return from onActivityResult method). As the data intent being null will always end up in crashing the app, there is no point to continue onActivityResult method. Terminating the authorization process instead would be much more user-friendly solution.
Steps to verify
One of the scenarios to reproduce the crash: