This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
Add minus option to point #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MayGo
commented
Feb 7, 2018
MayGo
commented
boygirl
reviewed
Feb 7, 2018
| it("draws a path for a minus at the correct location", () => { | ||
| const pathResult = PathHelpers.minus(0, 0, 1); | ||
| const baseSize = 1.1 * size; | ||
| const lineHeight = baseSize / 0.15; |
There was a problem hiding this comment.
I think your lineHeight calculation here differs from the implementation.
|
@MayGo Thank you for this addition. The spec you added is currently failing, but I will merge this change if you make it pass. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.