Merge pull request #1715 from FormidableLabs/bug/safe-stringify

use safe stringify
FormidableLabs · Oct 14, 2020 · 23a65fc · 23a65fc
2 parents 9639dc5 + 946d8e6
commit 23a65fc
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/docs/package.json b/docs/package.json
@@ -85,4 +85,4 @@
     "deploy:stage": "formideploy deploy --staging",
     "deploy:prod": "formideploy deploy --production"
   }
-}
+}
diff --git a/packages/victory-shared-events/package.json b/packages/victory-shared-events/package.json
@@ -19,6 +19,7 @@
   "author": "Formidable",
   "license": "MIT",
   "dependencies": {
+    "json-stringify-safe": "^5.0.1",
     "lodash": "^4.17.19",
     "prop-types": "^15.5.8",
     "react-fast-compare": "^2.0.0",

diff --git a/packages/victory-shared-events/src/victory-shared-events.js b/packages/victory-shared-events/src/victory-shared-events.js
@@ -3,6 +3,7 @@ import React from "react";
 import PropTypes from "prop-types";
 import { PropTypes as CustomPropTypes, Events, Helpers, TimerContext } from "victory-core";
 import isEqual from "react-fast-compare";
+import stringify from "json-stringify-safe";
 
 export default class VictorySharedEvents extends React.Component {
   static displayName = "VictorySharedEvents";
@@ -171,7 +172,7 @@ export default class VictorySharedEvents extends React.Component {
             name,
             baseProps,
             childEvents,
-            JSON.stringify(this.state[name])
+            stringify(this.state[name])
           ];
 
           const sharedEvents = this.getCachedSharedEvents(name, sharedEventsCacheValues) || {