You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently VictoryCandlestick only renders one label per candle. Instead, VictoryCandlestick should render labels for high, low, close and open (and maybe keep label?) Each label should be able to be styled independently.
Proposed prop additions:
lowLabels: the label accessor function for the low label lowLabelComponent: the component to render for the low label highLabels highLabelComponent openLabelsopenLabelComponentcloseLabelscloseLabelComponentlabels: (existing prop) will now refer to a label rendered near the center of the candle labelComponent`: (existing prop) will now refer to a label rendered near the center of the candle
style: this prop should change to include namespaces for lowLabels, highLabels, openLabels and closeLabels. Styles suppled to the existing labels style namespace should be merged with other label styles so that users can easily define a single set of styles for all the different labels types, and override individual attributes as desired.
Label placement should have nice automatic default behavior for horizontal and vertical candle orientations
The text was updated successfully, but these errors were encountered:
boygirl
changed the title
VictoryCandlestick improvements
VictoryCandlestick label improvements
Apr 7, 2019
Currently
VictoryCandlestick
only renders one label per candle. Instead,VictoryCandlestick
should render labels forhigh
,low
,close
andopen
(and maybe keeplabel
?) Each label should be able to be styled independently.Proposed prop additions:
lowLabels
: the label accessor function for the low labellowLabelComponent
: the component to render for the low labelhighLabels
highLabelComponent
openLabels: (existing prop) will now refer to a label rendered near the center of the candle
labelComponent`: (existing prop) will now refer to a label rendered near the center of the candlestyle
: this prop should change to include namespaces forlowLabels
,highLabels
,openLabels
andcloseLabels
. Styles suppled to the existinglabels
style namespace should be merged with other label styles so that users can easily define a single set of styles for all the different labels types, and override individual attributes as desired.Label placement should have nice automatic default behavior for horizontal and vertical candle orientations
The text was updated successfully, but these errors were encountered: