Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VictoryCandlestick label improvements #1286

Closed
boygirl opened this issue Apr 5, 2019 · 0 comments
Closed

VictoryCandlestick label improvements #1286

boygirl opened this issue Apr 5, 2019 · 0 comments
Assignees

Comments

@boygirl
Copy link
Contributor

boygirl commented Apr 5, 2019

Currently VictoryCandlestick only renders one label per candle. Instead, VictoryCandlestick should render labels for high, low, close and open (and maybe keep label?) Each label should be able to be styled independently.

Proposed prop additions:

lowLabels: the label accessor function for the low label
lowLabelComponent: the component to render for the low label
highLabels
highLabelComponent openLabels openLabelComponent closeLabels closeLabelComponent labels: (existing prop) will now refer to a label rendered near the center of the candle labelComponent`: (existing prop) will now refer to a label rendered near the center of the candle

style: this prop should change to include namespaces for lowLabels, highLabels, openLabels and closeLabels. Styles suppled to the existing labels style namespace should be merged with other label styles so that users can easily define a single set of styles for all the different labels types, and override individual attributes as desired.

Label placement should have nice automatic default behavior for horizontal and vertical candle orientations

@boygirl boygirl changed the title VictoryCandlestick improvements VictoryCandlestick label improvements Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants