add diff labels and orientation support

[ashika01]

Fixes: #1286

Improvements on label support for victory-candlestick. This PR includes following label support for candlestick

• lowLabels
• lowLabelComponent
• highLabels
• highLabelComponent
• openLabels
• openLabelComponent
• closeLabels
• closeLabelComponent

There is also continued support for labels and labelComponent. style can be applied on all the different labels.

Also support top, bottom, left, right label orientation support for all the labels

TODO:

• regression testing
• demo update

[boygirl]

This is looking really good. I'm a little concerned about how getCandleWidth is working, but I need to think more about what has access to active. I would also really like to see more demos / stories

[boygirl]

This is a little confusing. You're using the same function that was in Candle and supplying it with the data props that you're calculating for each Candle. That mostly works, but active will not typically be defined at this level. Typically it would get added to state by Victory's event system.

[boygirl]

I'm confused about this function name. I don't think axis is accurate here.

[boygirl]

@ashika01 I've been trying out this branch, and looking for edge cases. There are a couple issues:

• tooltips don't look right with some labelOrientations. Here's some openLabel tooltips with labelOrientation: "top".

I'm also seeing a few console warnings in this situation: Warning: Failed prop type: Invalid prop orientation supplied to VictoryTooltip.

• It looks like the Box / Border primitive is trying to render elements with unexpected props:

I was also not able to alter the new labels via events. For example:

events={[{
  target: "data",
  eventHandlers: {
    onMouseOver: () => {
      return [
        {
          target: "openLables",
          mutation: () => {
            return { text: "YO" }
          }
        }
      ];
    }
  }
}]}

I'll look into the event issue if you'd prefer. It looks potentially confusing.

[ashika01]

Last commit include change in box plot as well