Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid prop type ouiaSafe #1656

Closed
patricknick opened this issue Jul 30, 2020 · 1 comment · Fixed by #1657
Closed

Invalid prop type ouiaSafe #1656

patricknick opened this issue Jul 30, 2020 · 1 comment · Fixed by #1657

Comments

@patricknick
Copy link

The Problem

The prop type of ouiaSafe is invalid. According to the doc, it should be PropTypes.bool:

victory/packages/victory-core/src/victory-container/victory-container.js

Line 24 in 453f2bb

ouiaSafe: PropTypes.boolean,

This results in a warning in Dev mode:
image

Related to this PR: #1654

Reproduction

You should see this when you start your project with a victory chart inside.

Versions

victory: 35.0.7
@corasan
Copy link

corasan commented Jul 30, 2020

I'm getting the same thing

@boygirl boygirl mentioned this issue Jul 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix ouiaSafe prop FormidableLabs/victory
2 participants
@corasan @patricknick