Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OUIA props to VictoryContainer #1654

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Conversation

dlabrecq
Copy link
Contributor

In order to better support automated testing, we would like to add the properties below to the root HTML element output by VictoryContainer.

These properties are defined by the Open UI Automation (OUIA) 1.0-RC spec.
https://ouia.readthedocs.io/en/latest/README.html#ouia-component

data-ouia-component-type
data-ouia-component-id
data-ouia-safe

Fixes #1624

@boygirl
Copy link
Contributor

boygirl commented Jul 29, 2020

@dlabrecq Thank you for this PR and for updating the docs to go along with. Everything looks great. Would this work also be an appropriate addition to victory-native? Let me know if so, and I can PR the corresponding changes there pretty quick. If not, would you please do add a note to the new props you've documented to make it clear that they are web only? Thanks!

@dlabrecq
Copy link
Contributor Author

Yes, these props would apply to React native as well.

@boygirl boygirl merged commit 453f2bb into FormidableLabs:main Jul 29, 2020
@boygirl
Copy link
Contributor

boygirl commented Jul 29, 2020

Great! I'll release a patch version and a docs update right now, and native changes this afternoon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OUIA props to VictoryContainer
2 participants