Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layout problems for stacked area charts with mixed negative and positive values #355

Closed
boygirl opened this issue Sep 16, 2016 · 7 comments · Fixed by #1832
Closed

layout problems for stacked area charts with mixed negative and positive values #355

boygirl opened this issue Sep 16, 2016 · 7 comments · Fixed by #1832
Assignees
@boygirl
Labels
Type: Bug 🐛 Oh no! A bug or unintentional behavior

Comments

@boygirl
Copy link
Contributor

boygirl commented Sep 16, 2016

From @boygirl on March 2, 2016 1:20

When stacked area charts have a mix of negative and positive data, the resulting charts look broken.

screen shot 2016-03-01 at 4 49 35 pm

Copied from original issue: FormidableLabs/victory-chart#132
@boygirl boygirl added the Type: Bug 🐛 Oh no! A bug or unintentional behavior label Sep 16, 2016
@stepek
Copy link

stepek commented May 16, 2017

👍

boygirl pushed a commit that referenced this issue Jul 17, 2018
@chrisbolin
add fast-deep-equal locally (#355)
acf7b4b
@swittk
Copy link

swittk commented May 11, 2019

Seems this hasn't been solved yet, yes?

@boygirl
Copy link
Contributor Author

boygirl commented May 13, 2019

True. In fact I'm not sure what the solution should be. Do you have thoughts on how charts like this should look, @swittk?

@salmituukka
Copy link

salmituukka commented May 14, 2019 •
edited
Loading

I think it would be great if one could set y0 property similar as area to stacked areas as well. This would solve at least my use case regarding this issue:
image
(salmituukka@122744e)

@boygirl
Copy link
Contributor Author

boygirl commented May 14, 2019

@salmituukka oh cool, I see what you're saying. Yeah!

@boygirl boygirl added Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release and removed Type: Bug 🐛 Oh no! A bug or unintentional behavior labels May 14, 2019
@boygirl boygirl self-assigned this May 14, 2019
@boygirl boygirl added Type: Bug 🐛 Oh no! A bug or unintentional behavior and removed Type: Enhancement ✏️ An enhancement or feature proposal that will be addressed after the next release labels May 14, 2019
@boygirl
Copy link
Contributor Author

boygirl commented May 14, 2019

Oh, actually. That wouldn't address the scenario where say, the middle stack has a negative value in it

@boygirl boygirl mentioned this issue May 14, 2019
Closed
@boygirl
Copy link
Contributor Author

boygirl commented May 14, 2019

@salmituukka I created a new issue for your suggestion

@jhumbug jhumbug linked a pull request May 5, 2021 that will close this issue
VictoryStack Custom Baseline Support #1832
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boygirl boygirl

Labels
Type: Bug 🐛 Oh no! A bug or unintentional behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

VictoryStack Custom Baseline Support FormidableLabs/victory
4 participants
@boygirl @swittk @stepek @salmituukka