Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add prop-types dep and improve package information #1063

Merged
merged 1 commit into from
Jul 28, 2018
Merged

add prop-types dep and improve package information #1063

merged 1 commit into from
Jul 28, 2018

Conversation

boygirl
Copy link
Contributor

@boygirl boygirl commented Jul 28, 2018 •
edited
Loading

closes #1060

@ryan-roemer
Copy link
Member

Haven’t had as chance to dig in yet, but did we remove the webpack external for the package?

@boygirl boygirl merged commit a8b9f6b into master Jul 28, 2018
@boygirl
Copy link
Contributor Author

boygirl commented Jul 28, 2018

@ryan-roemer sorry, I missed your comment. Dang page wasn't refreshed. Thanks for catching that. I'll remove it in a separate PR

@boygirl boygirl deleted the improvement/prop-types-dep branch July 28, 2018 03:20
@boygirl boygirl mentioned this pull request Jul 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prop-types should be a real dependency
2 participants
@boygirl @ryan-roemer