Fix/issue 895 1119 #1158
Merged
Fix/issue 895 1119 #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solve issue for vertical bars Finish getVerticalBarPath, add comments Remove edit to victory-bar story remove circle2 dependency, add helper methods to replace it Create helper geometry functions to reduce deplicated code in bar.js Lint code
- Translate code from getVerticalBarPath to horizontal case - Add Circle.ProtoType.solveY helper method
- Allow topLeft, topRight, bottomLeft, bottomRight fields - Still need to make it functional
- modify getCornerRadius helper function to look for topLeft, topRight (not just top) - create helper function getVerticalBarPoints to make getVerticalBarPath function smaller - add temporary solution for getHorizontalBarPath and getPolarBarPath (see TODO) Incorporate topLeft, topRight, etc. cornerRadius to horizontal bar - Add temporary solution for getVerticalPolarBar since it normally doesn't accept topLeft, topRight, etc. - Change cornerRadius function to satisfy linter - Try to change getVerticalBarPoints to satisfy linter Add cornerRadius topLeft, topRight etc to Polar Bars Change Z to z to pass tests
Closed
|
@boygirl Woohoo! Happy that this issue is finally resolved. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Adds support or
topLeft,topRight,bottomLeftandbottomRightvalues forcornerRadiusforVictoryBarfixes Feature: possibility to add top-left or top-right cornerRadius to VictoryBar #1119Prevents weird artifacts when bars with cornerRadius are too short fixes VictoryBar cornerRadius incorrect when value is 0 or small #895
@narinluangrath the fix for polar bar corner radius ended up being super fiddly!