Feature/blacklist with regex #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 17, 2019 18:27
- Adds regExp custom proptype - Updates voronoi-helpers's getDatasets method
|
@narinluangrath nice! Thanks for this feature |
brendanmorrell
added a commit
to brendanmorrell/victory
that referenced
this pull request
Feb 19, 2022
typings for ```voronoiBlacklist``` do not currently include regular expressions, which are supported as of [this](FormidableLabs#1278) PR. This changes the type so ```voronoiBlacklist``` correctly allows both strings and regular expressions.
dlcartright
pushed a commit
that referenced
this pull request
Mar 5, 2022
typings for ```voronoiBlacklist``` do not currently include regular expressions, which are supported as of [this](#1278) PR. This changes the type so ```voronoiBlacklist``` correctly allows both strings and regular expressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements feature #1275
Allows you to define the voronoiBlacklist prop using strings or regular expressions. I decided to use lodash's isRegExp function instead of
x instanceof RegExpbecause it seemed more robust.