New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/reverse victory stack render #1292

Merged

boygirl merged 3 commits into master from improvement/reverse-victory-stack-render

Apr 10, 2019

Contributor

boygirl commented Apr 10, 2019 •

edited

Loading

This PR reverses the render order for children of VictoryStack. This is desirable in scenarios such as:

Stacked VictoryArea or VictoryBar charts with strokeWidth styles
Stacked charts with labels
Stacked VictoryBar charts with cornerRadius as in Stacked bar chart and cornerRadius #1289

closes #1288
closes #1289

boygirl added 3 commits

April 10, 2019 13:38


          reverse render order of VictoryStack children

c41e449


          change where children are reversed, add comment

25521dc


          prettier

f724d4c

boygirl merged commit 5d75d74 into master

boygirl deleted the improvement/reverse-victory-stack-render branch

April 10, 2019 21:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet