Last frame of animation should not be skipped #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spectacle transitions skipped the last render causing incomplete effects and partially loaded slides. Forcing the terminating case should fix the issue.
|
@fbarbat looks good! Thanks for this fix. I can release a patch today, and speak with the spectacle maintainer tomorrow. FWIW though, that project is undergoing a rewrite, and will use Neat cover letter :) We have a couple location-specific positions open at the moment. Check them out here: https://formidable.com/careers/#open-positions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spectacle transitions skip the last render causing incomplete effects and partially loaded slides.
To reproduce it just inspect the DOM after the slide transitions and confirm that the final CSS transform values such as scale or translate3d do not reach final values (i.e. scale=1 or translate3d=0).
See https://codesandbox.io/s/simple-spectacle-example-e96d2 as an example. In this specific case, scale does not reach 1 but a number close to it such as 0.993772. In this case maybe it is not noticeable at a first look, but if the slide has many more components or the hardware is stressed, it could stop at lower values causing a very noticeable glitch in the layout.
Forcing the render on the terminating case should fix the issue.
Once this is fixed and released, Spectacle dependency on victory should be updated.
By the way, I am fixing this bug since I am implementing a cover letter using Spectacle to find a new job. Do you want to hire me? :D Please see https://fernandobarbat.com Thanks!