-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/audit victory scatter typescript props #1510
Conversation
…catter data, updated victory core prop and victory scatter prop ts defs
…th surrogate pairs rather than fromCodePoint for VictoryScatter demo
samples?: number; | ||
size?: number | { (data: any): number }; | ||
sortOrder?: string; | ||
style?: VictoryStyleInterface; | ||
symbol?: ScatterSymbolType | { (data: any): ScatterSymbolType }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you check on ScatterSymbolType
for me? I think it might be incomplete for recent props changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! Approved pending minor question.
Approved! Thank you! |
Audit of prop typescript defs for VictoryScatter.