Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typescript prop defs and demo for VictoryBrush Line #1515

Merged
merged 3 commits into from
Apr 21, 2020
Merged

Add typescript prop defs and demo for VictoryBrush Line #1515

merged 3 commits into from
Apr 21, 2020

Conversation

maddles
Copy link
Contributor

@maddles maddles commented Apr 20, 2020

  • Add typescript defs for Victory Brush Line
  • Add typescript demo for Victory Brush Line

@maddles maddles requested a review from boygirl April 20, 2020 21:03
@wsparsons wsparsons mentioned this pull request Apr 20, 2020
Closed
24 tasks
boygirl
boygirl reviewed Apr 20, 2020
View reviewed changes
packages/victory-brush-line/src/index.d.ts
handleComponent?: React.ReactElement;
handleStyle?: VictoryStyleObject;
handleWidth?: number;
lineComponent?: React.ReactElement;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is missing an id prop.

boygirl
boygirl suggested changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@boygirl boygirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing one minor prop. Otherwise approved

@boygirl
Copy link
Contributor

boygirl commented Apr 21, 2020

Approved!

@maddles maddles merged commit 5c5d6be into master Apr 21, 2020
@maddles maddles deleted the task/victory-brush-line-typescript-props branch April 21, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boygirl boygirl boygirl requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maddles @boygirl