Audit typescript props and add a demo for VictoryCursorContainer #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maddles
commented
Apr 24, 2020
•
maddles
commented
- Enforce number from cursorLabel function
- Added VictoryCursorContainer demo
24 tasks
boygirl
reviewed
Apr 26, 2020
| @@ -4,7 +4,7 @@ import { VictoryContainerProps, CursorData } from "victory-core"; | |||
| export interface VictoryCursorContainerProps extends VictoryContainerProps { | |||
| cursorComponent?: React.ReactElement; | |||
| cursorDimension?: "x" | "y"; | |||
| cursorLabel?: (point: CursorData) => void; | |||
| cursorLabel?: (point: CursorData) => number; | |||
There was a problem hiding this comment.
This is incorrect. cursorLabel should be able to return a string, too.
There was a problem hiding this comment.
Shall I do string | number, or is there a situation where void should be accepted too?
There was a problem hiding this comment.
Yeah, folks sometimes return null to render no label for a given data point. Let's leave this one as flexible as possible.
boygirl
suggested changes
Apr 26, 2020
|
Approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.