Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit VictoryLine typescript prop defs. Added eventkey, interpolation… #1535

Merged
merged 2 commits into from
Apr 27, 2020
Merged

Audit VictoryLine typescript prop defs. Added eventkey, interpolation… #1535

merged 2 commits into from
Apr 27, 2020

Conversation

maddles
Copy link
Contributor

@maddles maddles commented Apr 24, 2020

Audit DefinitelyTyped types for VictoryLine.

Added: eventKey, interpolation, origin

Extended: VictoryLabelableProps, VictoryMultiLabelableProp

kale-stew
kale-stew approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@kale-stew kale-stew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

boygirl
boygirl approved these changes Apr 26, 2020
View reviewed changes
Copy link
Contributor

@boygirl boygirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@maddles maddles merged commit 38437cc into master Apr 27, 2020
@maddles maddles deleted the task/audit-victory-line-typescript-props branch April 27, 2020 14:02
@wsparsons wsparsons mentioned this pull request Apr 29, 2020
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boygirl boygirl boygirl approved these changes

@kale-stew kale-stew kale-stew approved these changes

@wsparsons wsparsons Awaiting requested review from wsparsons

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maddles @boygirl @kale-stew