Audits and Adds typescript props, definitions, and demo: VictoryZoomContainer #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsparsons
changed the title
24 tasks
wsparsons
force-pushed
the
task/audit-victory-zoom-container-typescript-props
branch
2 times, most recently
from
2f66b9f
to
0e08423
Compare
wsparsons
changed the title
boygirl
approved these changes
Apr 30, 2020
wsparsons
force-pushed
the
task/audit-victory-zoom-container-typescript-props
branch
from
a9e264c
to
ffb1577
Compare
wsparsons
commented
Apr 30, 2020
| @@ -123,7 +118,7 @@ export default class App extends React.Component { | |||
|
|
|||
| getZoomDomain() { | |||
| return { | |||
| y: [random(0, 0.4, 0.1), random(0.6, 1, 0.1)] | |||
There was a problem hiding this comment.
ended up removing this since https://lodash.com/docs/4.17.15#random says the third argument should be a boolean. not sure if the 0.1 was intentional or if it should have a boolean value.
wsparsons
commented
Apr 30, 2020
| @@ -61,11 +61,6 @@ class CustomChart extends React.Component { | |||
| x: [data[0].x, last(data).x] | |||
| }; | |||
| } | |||
| getZoomFactor() { | |||
There was a problem hiding this comment.
ended up removing this uninvoked function. not sure if this should be used in the demo and somehow got missed?
…ccount for array of dates
…count for array of dates
wsparsons
force-pushed
the
task/audit-victory-zoom-container-typescript-props
branch
from
ffb1577
to
68a8f49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CursorDatatoCoordinatesPropTypeVictoryBrushContainerPropsandVictoryBrushContainerDemoto useDomainTupleinsteadRangeTupleVictoryZoomContainerDemoVictoryZoomContainerPropsinterfaceVictoryZoomContainerPropsinterface that do not belong