Fix axes paddings for different orientation options #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@boygirl please, take a look. |
|
@glvnsky thank you for this fix. These changes look correct to me. Mind running |
|
@boygirl updated pull request. Sorry that I missed it. Thank you very much for quick response and awesome library too :) |
|
Thank you! I'll get a patch released for you this afternoon |
|
Thanks! I'll do my best in future contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found bug with paddings when axis "orientation" prop is set.
The trick is to take padding for axis depend on "orientation" prop if it is set. Also add story for reproduction and check.