-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Label improvements #1625
Merged
Merged
Label improvements #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…larDependentAxis and polarIndependentAxis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds improvements for labels and builds on the label background feature work in #1583
This PR includes several breaking changes related to label and tooltip layout. Most of these changes will be minor, visual changes, but style updates may be necessary.
A more complete list of changes: (Full documentation of new and changed props ~Monday)
backgroundStyle
forVictoryLabel
backgroundPadding
forVictoryLabel
labelPlacement
toVictoryPie
. Possible values are"vertical"
"parallel"
and"perpendicular"
as in polar labels.labelPosition
onVictoryPie
(previouslystartAngle
andendAngle
were inverted) This is a breaking changeflyoutPadding
prop toVictoryTooltip
to give finer control over spacing between label and flyout edgestooltip
theme props to tooltips in all chart types this is a breaking changetooltip
themes to addflyoutPadding
this is a breaking changepolarAxis
,polarDependentAxis
andpolarIndependentAxis
namespaces in themes. These are merged with other Axis namespacespolarDependentAxis
theme toVictoryTheme.material
this is a breaking changeboxplot
andcandlestick
themes this is a breaking changematerial
andgrayscale
default label font so that they use universally available fontsVictoryPortal