Feature/aria label & tab index: scatter, voronoi, candlestick, errorbar #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ljones87 changes are looking good. It looks like this feature is nearly complete! |
ljones87
force-pushed
the
feature/aria-label-scatter-etc
branch
from
3fd3c00
to
cdbd90c
Compare
Base automatically changed from
feature/aria-label-others
to
feature/aria-label
October 5, 2020 18:08
ljones87
force-pushed
the
feature/aria-label-scatter-etc
branch
from
cdbd90c
to
ac7ac91
Compare
ljones87
force-pushed
the
feature/aria-label-scatter-etc
branch
from
ac7ac91
to
e2baa38
Compare
ljones87
changed the title
|
Will merge this guy unless there are any other comments/needed changes? |
|
Yep! This looks good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This, hopefully final, PR should wrap up adding tabIndex and ariaLabel to the rest of the primitives: ErrorBar, Candle, Point, and Voronoi 🎉
Demos added for the corresponding
Victoryparent charts.I did not include all charts available in Victory's library since others, for example histogram, use the same primitive components so I didn't feel the need to demo those as well. Happy to do so if preferred otherwise!
Added tests to spec files as well.