Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add static defaultEvents to VictoryTooltip type #1751

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Add static defaultEvents to VictoryTooltip type #1751

merged 1 commit into from
Dec 1, 2020

Conversation

becca-bailey
Copy link
Contributor

Fixes #1549

@becca-bailey becca-bailey requested review from boygirl and mariano-formidable and removed request for boygirl December 1, 2020 21:29
boygirl
boygirl approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@boygirl boygirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the fix.

@boygirl boygirl merged commit b807a6e into main Dec 1, 2020
@boygirl boygirl deleted the bug/add-default-events-typing-to-victory-tooltip branch December 1, 2020 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boygirl boygirl boygirl approved these changes

@mariano-formidable mariano-formidable Awaiting requested review from mariano-formidable

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Static member defaultEvents on VictoryTooltip is not in TypeScript typings
2 participants
@becca-bailey @boygirl