-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format Data from Domain #1827
Format Data from Domain #1827
Conversation
note: still need to refactor the function to be less verbose |
open question: For the chart types with non-typical accessors (VictoryBoxPlot, VictoryCandlestick, VictoryErrorbar) should we switch their groupComponent to VictoryClipContainer in order to keep them within their Chart wrapper when setting domain? |
I feel like if we went that route for some, it would make more sense to use a clipped group for all the components and just roll with the breaking change. |
…with it's special accessors
…based on it's special accessors
At this point I believe everything's accounted for. I even went through and found several issues from the past that were related to this and tested their use cases to make sure this solves it. It allowed me to find a VictoryStack issue that I addressed. |
…s that call formatData directly don't run the method.
@jhumbug This is missing data filtering on |
Approved! Nice work, @jhumbug |
yay! thank you |
Adds a format data function in global data util to keep data points from reaching out of their supplied domains and to remove points that are entirely outside of the domain.