Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update export syntax in victory index #1926

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

becca-bailey
Copy link
Contributor

I noticed that we also have a large default export in victory/index. Updating this to the ESM export syntax shouldn't change the imports.

@ryan-roemer
Copy link
Member

The existing export was a named export list export { ONE, TWO, ... } it wasn't a export default { ONE, TWO, ... }, so it can stay as-is if we want. But this change is fine if we want to just do re-exports at the point of import. I'm cool with whatever you and @boygirl want!

@becca-bailey
Copy link
Contributor Author

Oh, okay! I missed that. This was a two second change, so we can close it if it doesn't make a difference!

@boygirl
Copy link
Contributor

boygirl commented Aug 4, 2021

@beccanelson Let's merge this because it's nicer. I don't think we need to make a patch just for this change though.

@becca-bailey becca-bailey merged commit eb6d323 into main Aug 4, 2021
@becca-bailey becca-bailey deleted the improvement/update-default-export-in-index branch October 8, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants