Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix font stack and correct margins in docs #2070

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

melvin-chen
Copy link
Member

@melvin-chen melvin-chen commented Jan 25, 2022

Fixes up the font stack that appears on the docs page and matches the margins with Renature:

Proposed:

image

image

Current:

image

image

@melvin-chen
Copy link
Member Author

Hey @becca-bailey I had a ticket open to fix this on the formidable dot com side. I'm not super sure how to deploy this to a surge or to the actual docs site, or if I even have the permissions to do that, but it looks more correct on my end when I run yarn start in docs in this PR. Let me know what you think!

@ryan-roemer
Copy link
Member

@melvin-chen it auto-deploys per-PR (here: https://formidable-com-victory-staging-2070.surge.sh/open-source/victory/ ) and to production on merge to main branch.

Copy link
Contributor

@becca-bailey becca-bailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants