feat: Add VictoryNativeBrushLine component #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nit - I think this just got carried over during a copy/paste.
This brings `VictoryBrushLine` parity to `victory-native`. The implementation is a combination of techniques used in `victory-native`’s `VictoryContainer`, `Portal`, and the standard way of bringing components to RN. Ultimately we still wrap the component with `wrapCoreComponent`, but before doing so we: 1. Extend the the component and override its render method so that it renders a valid `react-native-svg` component (much like how `Portal` is done). 2. Remap the relevant `static defaultEvents` to their native equivalents e.g `onTouchStart -> onMouseDown` (I feel like I'm kind of hacking this, and there's a better way to do so?) 3. Create a set of `PanResponders` like in the native `VictoryContainer` that will respond to the touch start/move/end events that are attached to each brush line. Adds typings/smoke-test Docs to come in future commit
This adds a `VictoryBrushLine` examples screen to the native app. It copies/converts the existing web examples into native. (also fixes prettier error that caused CI to fail in previous commit) Update brush-line-screen.tsx
zibs
force-pushed
the
zibs/native-victory-brush-line
branch
from
598abc7
to
0f86f1f
Compare
becca-bailey
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
This looks good to me! I think the only comment I have is that eventually we want to move away from extending classes for victory-native components, because this makes it harder to change the base components. In my perfect world, we would use composition to pass in alternate props for victory-native rather than extending a class. HOWEVER, this is outside the scope for this change, and we can continue using this syntax until we're able to prioritize updating this pattern across the board.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings
VictoryBrushLineparity tovictory-native.The implementation is a combination of techniques used in
victory-native’sVictoryContainer,Portal, and the standard way of bringing components to RN.Ultimately we still wrap the component with
wrapCoreComponent, but before doing so we:react-native-svgcomponent (much like howPortalis done).static defaultEventsto their native equivalents e.gonTouchStart -> onMouseDown(I feel like I'm kind of hacking this, and there's a better way to do so?)PanResponderslike in the nativeVictoryContainerthat will respond to the touch start/move/end events that are attached to each brush line.Adds typings/smoke-test
Adds docs/screen to RN demo app
Resolves #2072
This actually requires #2071 to function correctly on Android due to the touch events issue.
Screen.Recording.2022-01-28.at.4.56.29.PM.mov
Screen.Recording.2022-01-28.at.4.57.13.PM.mov