-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add victory-vendor package for d3 dependencies #2204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me! @ryan-roemer You can go ahead and merge whenever you are ready, and then we can get this package released.
I'm not sure why there is a diff in Chromatic, but there are no visible changes. I'm assuming there is just some microscopic difference because of a slight change to the d3 scale that it is picking up on. I'll approve those changes. |
@ryan-roemer I'm reviewing changes in chromatic, and there do appear to be a couple places where commenting out those scales changed things. I think we needed one of those log scales? There are also a few mysterious markup changes in the |
@becca-bailey Sounds good and good to know those Chromatic tests can flag this for us!!! I'm holding off pending your investigation. |
This reverts commit ec078d5.
From what I can tell, the axis label changes introduced in this PR have to do with changes introduced to the This showed up as a diff in Chromatic, and users might notice some minor changes to the way log scale values are formatted by default. We will include some guidance in the release notes for the next version about Victory's |
This PR addresses the ESM-only package issues from d3 packages discussed in #2124
We take a two-path approach in that ESM uses the real ESM-only packages and CJS uses our vendored (transpiled) package versions.
Tasks
Stuff we still need to do:
victory-native
still works as expected.victory-vendor
it.skip()
-ed Karma tests.yarn nps lint.docs
command does not presently run in CI. It has a unique constraint in that both the root anddocs
dependencies need to be installed for it to succeed. We can either fix / enable here or maybe ticket for later.Work
New stuff:
victory-vendor
package.Chores:
Fixes / infra:
Release notes
We'll be publishing a new package
victory-vendor
, so I'm not sure if there are extra kinks in the release script there.Also, for this release, since we've got a new vendor dependency scheme in the package, there are potentially some unforeseen issues that we won't be able to fully suss out until we fully release.