Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert victory and victory-chart tests to jest #2246

Merged
merged 4 commits into from
May 20, 2022
Merged

Convert victory and victory-chart tests to jest #2246

merged 4 commits into from
May 20, 2022

Conversation

becca-bailey
Copy link
Contributor

  • Tests for victory and victory-chart
  • Adds user props to VictoryAxis

scottrippey
scottrippey approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@scottrippey scottrippey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Seems nice and easy to convert these tests, and I'm looking forward to getting my hands dirty with this soon.

test/jest/victory-chart/victory-chart.test.js Show resolved Hide resolved
@becca-bailey becca-bailey merged commit 9218fcd into main May 20, 2022
@becca-bailey becca-bailey deleted the chore/victory-tests branch May 20, 2022 18:16
@becca-bailey becca-bailey added this to the Overhaul Testing milestone May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heythisispaul heythisispaul heythisispaul left review comments

@scottrippey scottrippey scottrippey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Overhaul Testing
Development

Successfully merging this pull request may close these issues.
3 participants
@becca-bailey @scottrippey @heythisispaul