Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

victory-vendor: script cleanup and exports enhancements #2264

Merged
merged 2 commits into from
May 30, 2022

Conversation

ryan-roemer
Copy link
Member

Adds the following to our package.json:exports for more flexible consumption:

  • Add package.json:exports for package.json. This is generally useful to have for npm packages using exports to introspect the project itself.
  • Add package.json:exports for lib/* consumers can point to CommonJS directly.
  • Add package.json:exports for es/* consumers can point to ESM directly.

Additional things:

  • Fix our build.js script to not errantly output an empty victory-vendor/d3-* directory.

Fixes #2250

Copy link
Member

@scottrippey scottrippey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that d3-* folder! I was pretty confused about its existence :)
Tested the builds locally, worked great.

packages/victory-vendor/scripts/build.js Show resolved Hide resolved
packages/victory-vendor/package.json Outdated Show resolved Hide resolved
@ryan-roemer
Copy link
Member Author

@becca-bailey thanks for the review!

@scottrippey thanks for the review and comments! I think 537219d takes care of everything for you?

Copy link
Member

@scottrippey scottrippey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the answers.

@ryan-roemer ryan-roemer merged commit 4428eb2 into main May 30, 2022
@ryan-roemer ryan-roemer deleted the chore/victory-vendor-cleanup branch May 30, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

victory-vendor: misc improvements
3 participants