Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript: fix a few build issues #2285

Merged
merged 3 commits into from
Jun 4, 2022
Merged

TypeScript: fix a few build issues #2285

merged 3 commits into from
Jun 4, 2022

Conversation

scottrippey
Copy link
Member

@scottrippey scottrippey commented Jun 3, 2022 •
edited
Loading

Fixes:

  • Use named import for addEvents > Transition dependency
  • Properly type the context property for class components, so that it doesn't get initialized
  • Adds "optional chaining" transpilation to Babel

Testing

These issues were all found in React Native, although it's not specific to that.
To test:

cd demo/rn
yarn start

Open in iOS simulator, and verify that all demos are working as expected.

image

@scottrippey scottrippey marked this pull request as ready for review June 3, 2022 22:49
@scottrippey
Copy link
Member Author

2 things worth noting …

  1. If we switched to babel-env it might’ve been easier to catch the “optional chaining” support
  2. We still need to convert victory-utils to TS, which would catch the named import bug

@scottrippey scottrippey merged commit e79942c into main Jun 4, 2022
@scottrippey scottrippey deleted the fix-build branch June 4, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@becca-bailey becca-bailey becca-bailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottrippey @becca-bailey