Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS migrate: add events #2306

Merged
merged 11 commits into from
Jun 20, 2022
Merged

TS migrate: add events #2306

merged 11 commits into from
Jun 20, 2022

Conversation

scottrippey
Copy link
Member

@scottrippey scottrippey commented Jun 17, 2022 •
edited
Loading

What

  • Migrates the final part of victory-utils: add-events!
  • With this conversion, we can now migrate other Victory components, like victory-line.

@scottrippey scottrippey changed the base branch from main to chore/source-maps June 17, 2022 22:09
@scottrippey scottrippey marked this pull request as draft June 17, 2022 22:11
@scottrippey scottrippey marked this pull request as ready for review June 17, 2022 22:16
@scottrippey scottrippey changed the base branch from chore/source-maps to main June 17, 2022 22:18
@scottrippey scottrippey mentioned this pull request Jun 20, 2022
Closed
gksander
gksander approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

packages/victory-core/src/victory-util/add-events.tsx Outdated Show resolved Hide resolved
packages/victory-core/src/victory-util/add-events.tsx Show resolved Hide resolved
@scottrippey scottrippey merged commit 99ce3c5 into main Jun 20, 2022
@scottrippey scottrippey deleted the ts-migrate/add-events branch June 20, 2022 20:10
@scottrippey scottrippey mentioned this pull request Jun 21, 2022
Closed
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gksander gksander gksander approved these changes

@becca-bailey becca-bailey Awaiting requested review from becca-bailey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottrippey @gksander