Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lodash identity with native code #2829

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Replace lodash identity with native code #2829

merged 2 commits into from
Mar 12, 2024

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Mar 12, 2024

Replace lodash identity with native code

Copy link

changeset-bot bot commented Mar 12, 2024

🦋 Changeset detected

Latest commit: 842fcf2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
victory-core Patch
victory-area Patch
victory-axis Patch
victory-bar Patch
victory-box-plot Patch
victory-brush-container Patch
victory-brush-line Patch
victory-candlestick Patch
victory-canvas Patch
victory-chart Patch
victory-create-container Patch
victory-cursor-container Patch
victory-errorbar Patch
victory-group Patch
victory-histogram Patch
victory-legend Patch
victory-line Patch
victory-native Patch
victory-pie Patch
victory-polar-axis Patch
victory-scatter Patch
victory-selection-container Patch
victory-shared-events Patch
victory-stack Patch
victory-tooltip Patch
victory-vendor Patch
victory-voronoi-container Patch
victory-voronoi Patch
victory-zoom-container Patch
victory Patch
victory-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
victory ⬜️ Ignored (Inspect) Visit Preview Mar 12, 2024 5:48pm

Copy link
Member

@Burnett2k Burnett2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used? Doesn't look like any implementations were updated

Burnett2k
Burnett2k previously approved these changes Mar 12, 2024
@carbonrobot
Copy link
Contributor Author

Its used in the same file, so it doesnt show in the diff

const predicateFunction = predicate || identity;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants