Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor victory-portal to remove dependency on react-dom #2870

Merged
merged 6 commits into from
May 17, 2024

Conversation

KenanYusuf
Copy link
Contributor

In #2799 we refactored the victory-portal component from a class component to function. However, during the refactor we unintentionally introduced react-dom as a dependency with the createPortal function, creating a huge increase in bundle size.

This PR uses an alternate approach to portaling.

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 10:32am

Copy link

changeset-bot bot commented May 16, 2024

⚠️ No Changeset found

Latest commit: 7e26e9d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KenanYusuf KenanYusuf merged commit ffc9841 into victory-container-rewrite May 17, 2024
2 checks passed
@KenanYusuf KenanYusuf deleted the victory-portal branch May 17, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants