Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap(CDN) version outdated #1892

Closed
pattyland opened this issue Aug 30, 2013 · 8 comments
Closed

Bootstrap(CDN) version outdated #1892

pattyland opened this issue Aug 30, 2013 · 8 comments

Comments

@pattyland
Copy link

The version of the Bootstrap(CDN) on http://fortawesome.github.io/Font-Awesome/get-started/ is still 2.3.2, may you should update it to 3.0?

@tagliala
Copy link
Member

FA 3.2.1 is not yet 100% compatible with BS 3.0

~ 40 icons are missing, there are minor css issues here and there, FA's syntax is obsolete

@pattyland
Copy link
Author

Ok, then this should be even more important than the link to it ;)

Sent from Mailbox for iPhone

On Sat, Aug 31, 2013 at 12:29 PM, Geremia Taglialatela
[email protected] wrote:

FA 3.2.1 is not yet 100% compatible with BS 3.0

~ 40 icons are missing, there minor css issues here and there, the syntax is obsolete

Reply to this email directly or view it on GitHub:
#1892 (comment)

@craigh
Copy link

craigh commented Sep 1, 2013

do you plan a version of FA that is compatible with Bootstrap 3?

@tagliala
Copy link
Member

tagliala commented Sep 1, 2013

you are free to use FA 3.2.1 with BS 3.0, I'm already doing it, but:

  • icons are not paired with glyphicons (take a look at: http://tagliala.github.io/vectoriconsroundup/ look at the red rows. Yellow rows are fixed in 4.0.0-wip)
  • we can improve performance with a new syntax, just like glyphicons' glyphicon glyphicon-icon
  • we can remove some unneeded stuff from stylesheets (universal selectors to override BS 2.* icon-*)
  • we can improve variable names to match BS3.0's ones (only for less and scss users)

The only css bug I found is #1708 and is already fixed in 4.0.0-wip branch.

Icons are up to Dave, I can't do anything about that

@phaidon
Copy link

phaidon commented Sep 3, 2013

I can not understand why bootstrap dropped the icon class.

Does this mean I have to rename icon to glyphicon in the Font-Awesome css?

@tagliala
Copy link
Member

tagliala commented Sep 3, 2013

@phaidon I suppose for at least 2 reasons

  1. Performance (icon-* is a very bad universal selector)
  2. Glyphicons were intended to be a separate project, then they were merge back in the main BS 3.0 repository between RC1 and RC2

If you are using FA with BS 3.0, keep using the old syntax: renaming is not needed (and will break things).

@krainboltgreene
Copy link

Is there a pull request open for these missing pieces/renames? @davegandy

@craigh craigh mentioned this issue Sep 8, 2013
29 tasks
@tagliala
Copy link
Member

This should not be an issue anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants