btn-large height changes with icon in btn-group

[misino]

When you have 2 large buttons in btn-group and in first button is icon and in second buttons there isnt icon. The button with icon is a little bit larger.

My configurations Ubuntu, Firefox (version 18).

You can see difference on following image.

[tagliala]

Same here (bootstrap 2.2.2 + fontawesome 3.0.2 + ubuntu 12.10 + firefox 18): http://jsfiddle.net/5EHaL/

This is an issue related to: #635 and the effin line-height: normal;

Since .btn is fine and the issue seems related to .btn-large, a simple workaround is:

.btn-large i[class^=icon] {
    line-height: inherit !important;
}

http://jsfiddle.net/5EHaL/3/

Note: this workaround may have unwanted side effects

PS: why are you using span instead of i for icons?

[davegandy]

Hmm. I'll look into this for 3.1.0.

[thomaskraus]

This workaround will preserve the original line-height:

.btn-large i[class^=icon] {
  float: left;
  line-height: inherit !important;
}

[tagliala]

I think this one will be fixed in 4.0.0 with the new syntax. It should be due to *[class="icon-"] stuff

[davegandy]

Confirmed, fixed in 4.0.0-wip branch. Thanks for adding the visual test, @tagliala!