Fix definitions for DOM interface #14586
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOM interfaces were off slightly from published API. Adjusted them so TS users can use accurately
|
I am a typescript user and looking to use some of the SVG APIs in my project. I noticed the definitions are off from your actual API. I didn't review all of your interfaces, but DOM ones were quick fixes since I need them in m y project. I am shimming my project with these definitions, but thoughts others may end up in the same boat. |
|
Hi! Thanks for this PR. I've assigned @mlwilkerson so he can take a look |
|
Any chance this is going to get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOM interfaces were off slightly from published API. Adjusted them so TS users can use accurately
I understand that:
I understand that it will not be merged and I will not be listed as a contributor on this project.