Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for font smoothing in Firefox 25 on Mac OS X #1727

Merged
merged 1 commit into from
Aug 21, 2013
Merged

Added support for font smoothing in Firefox 25 on Mac OS X #1727

merged 1 commit into from
Aug 21, 2013

Conversation

MartinSeeler
Copy link

Even though this vendor prefix will be available earliest in Firefox 25+ and only on Mac OS X, it's not a big deal to include it now.

Related to issue #1591
Based on https://bugzilla.mozilla.org/show_bug.cgi?id=857142#c83

@tagliala
Copy link
Member

tagliala commented Aug 6, 2013

can you please post a screenshot with the difference?

@MartinSeeler
Copy link
Author

Unfortunately not. I don't have a Mac and the ones I know are on vacation...But I will see what I can do.
This addition was purely precautionary and based on the comments in the bugzilla comments, where it seems to work properly.

BTW: I've seen that you already using this in your fork and didn't notice any differences on OSX 10.7.5.
Is it possible that this will only affect OSX 10.6 und lower?
I've got this idea from comment #89, where it says:
+skip-if(!cocoaWidget||OSX==10.6||OSX==10.7)) != osx-font-smoothing.html osx-font-smoothing-ref.html

@winterbe
Copy link

winterbe commented Aug 8, 2013

This is taken from the current FF Nightly Build on Mac OSX 10.8.4.

Without Font-Smooting:
Without Font-Smoothing

With Font-Smooting:
With Font-Smoothing

@MartinSeeler
Copy link
Author

Thx for the shot!

In my opinion the compass and edit icons looks better than before. On the other side, the code icon is now a bit too thin?

@winterbe
Copy link

winterbe commented Aug 8, 2013

The icons look the same as in webkit browsers. Without Font Smoothing the icons in FFOX all look too thick and blurred.

tagliala added a commit that referenced this pull request Aug 21, 2013
Added support for font smoothing in Firefox 25 on Mac OS X
@tagliala tagliala merged commit a43d6eb into FortAwesome:4.0.0-wip Aug 21, 2013
@MartinSeeler MartinSeeler deleted the 4.0.0-wip branch August 21, 2013 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants