Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DomAttributes to typescript typedefs #215

Conversation

stephen-hopkins
Copy link

This resolves #151 by adding suggested React.DOMAttributes to Props interface. Allows use of onClick and other properties in typescript. No test added as it's an addition to type definitions only, ie non functional.

@robmadole
Copy link
Member

@stephen-hopkins would React.HTMLAttributes be better?

@Rycochet
Copy link

It should be React.DOMAttributes<SVGSVGElement> to be absolutely correct (it's an <svg>...</svg> element, not a normal HTML element) - this does break mask in Props currently, but I'm not sure is FA is making use of the non-string properties added to the type.

@dangayle
Copy link

This one I think is better: #283

@robmadole
Copy link
Member

I merged #283 and that has been released.

@robmadole robmadole closed this Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing properties in Typescript typedefs
4 participants