Feat/web #23
Merged
Feat/web #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simple backend layout work more styling header styling more styling initial work on diffs working on styling and comparisons more ui wip ui command introduced introducing monaco editor basic editing works menu added styling updates more styling more styling opening browser window upon ui startup basic run triggering wip uvicorn added styling and other fixes window title ui fixes, ui command refactored refactor wip refactor wip refactor wip refactor, tests, deps update refactor, updates, styling more styling updates fixes and styling tokens per second, styling, bugfixes wip monaco editor used to show diffs quick fixes error experience
meal
requested changes
Jul 24, 2023
There was a problem hiding this comment.
also there's single test that's failing:
______________________________________________________________________________________________________________________________________ TestPromptConfigLoader.test_basics _______________________________________________________________________________________________________________________________________
self = <test_run_collection.TestPromptConfigLoader object at 0x7fced98a4310>
def test_basics(self):
prompt_path = os.path.join(
THIS_FILE_DIR, "..", "fixtures", "run_collection", "basic.yaml"
)
assert os.path.exists(prompt_path)
assert os.access(prompt_path, os.R_OK)
loader = PromptConfigLoader()
prompt_config = loader.load_from_path(prompt_path)
assert prompt_config
collection = PromptRunCollection(prompt_config)
assert collection
assert collection.is_empty() == False
assert collection.has_done_runs() == True
> assert len(collection.runs) == 3
E assert 1 == 3
E + where 1 = len([<prr.runner.saved_prompt_run.SavedPromptRun object at 0x7fced973f730>])
E + where [<prr.runner.saved_prompt_run.SavedPromptRun object at 0x7fced973f730>] = <prr.runner.run_collection.PromptRunCollection object at 0x7fced98a7310>.runs
test/runner/test_run_collection.py:33: AssertionError
| @@ -17,7 +17,7 @@ pyyaml = "^6.0" | |||
| google-cloud-aiplatform = "^1.25.0" | |||
| huggingface-hub = "^0.14.1" | |||
| text-generation = "^0.5.2" | |||
| elevenlabs = "^0.2.18" | |||
There was a problem hiding this comment.
we need to bring it back, it crashes without it
prr/__main__.py
Outdated
| command = UIPromptCommand(parsed_args) | ||
| command.start() | ||
|
|
||
| if not check_if_prompt_exists(parsed_args["prompt_path"]): |
There was a problem hiding this comment.
if there's no file provided as an argument it just crashes
ideally, we want to raise an error and show available flags
meal
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.